GitHub Issue #180: config.scrub_fields is applied to config.person #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. |
rokob
reviewed
Jul 3, 2017
src/Scrubber.php
Outdated
| @@ -24,20 +26,35 @@ protected function setScrubFields($config) | |||
| } | |||
| $this->scrubFields = self::$defaults->scrubFields($fromConfig); | |||
| } | |||
|
|
|||
rokob
reviewed
Jul 3, 2017
src/Scrubber.php
Outdated
| $current = !$path ? $key : $path . '.' . $key; | ||
|
|
||
| if (in_array($current, $scrubber->getWhitelist())) { | ||
| return; |
There was a problem hiding this comment.
If person is in scrub_fields and data.person.username is in the whitelist, then I am pretty sure we would end up with data.person === '********' which I think is the correct behaviour that we want, but is not necessarily obvious. This only works at whitelisting things that would otherwise be scrubbed based on the exact key and not a earlier path component. i.e elements of the whitelist data.a.b.c.d will only be whitelisted if a, b, and c are not scrub_fields.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
scrub_whitelistconfig which allows to create exceptions to scrub fields based on an associative array dot notation.