Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower deployment target to iOS 9.0 #339

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Lower deployment target to iOS 9.0 #339

merged 1 commit into from
Dec 1, 2020

Conversation

GRiMe2D
Copy link
Contributor

@GRiMe2D GRiMe2D commented Nov 27, 2020

Description of the change

Removed all target overrides for iOS and macOS deployment target and set project wide. Lowered iOS deployment target from iOS 12.0 to iOS 9.0

Screen Shot 2020-11-27 at 1 30 19 PM

Screen Shot 2020-11-27 at 1 30 43 PM

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #338

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akornich akornich self-assigned this Nov 30, 2020
@akornich akornich added the build label Nov 30, 2020
Copy link
Contributor

@akornich akornich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GRiMe2D , thanks for the PR! One question - did you try building the SDK with these changes under Xcode 12?

@GRiMe2D
Copy link
Contributor Author

GRiMe2D commented Nov 30, 2020

@akornich yes, it compiles normally, but Xcode recommends to switch to iOS 12.

Xcode 12 only dropped iOS 8 support, but iOS 9 and later are accessible. I'm currently using my fork in a project and all seems running ok.

@akornich
Copy link
Contributor

@GRiMe2D , got it. The build issue under Xcode 12 was actually triggered within KSCrash codebase that we depend on and it seemed persistent until I bumped the min iOS target to v12. I know KSCrash guys are already looking into it on their side to have an actual fix. But since you confirmed your changes behave with Xcode 12 let's go with it. Thank you!

Copy link
Contributor

@akornich akornich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akornich akornich merged commit 52dbd64 into rollbar:master Dec 1, 2020
@GRiMe2D GRiMe2D deleted the lower-deployment-target branch December 1, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment target for Rollbar changed to iOS 12.0
2 participants