-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document exception level filters #366
Conversation
Previously we told people to go see another document without a link. That's not very user friendly. This also makes `404` "Ctrl+F"able.
👍 |
@@ -379,7 +379,14 @@ By default, all uncaught exceptions are reported at the "error" level, except fo | |||
- ```AbstractController::ActionNotFound``` | |||
- ```ActionController::RoutingError``` | |||
|
|||
If you'd like to customize this list, see the example code in ```config/initializers/rollbar.rb```. Supported levels: "critical", "error", "warning", "info", "debug", "ignore". Set to "ignore" to cause the exception not to be reported at all. | |||
If you'd like to customize this list, modify the example code in ```config/initializers/rollbar.rb```. Supported levels: "critical", "error", "warning", "info", "debug", "ignore". Set to "ignore" to cause the exception not to be reported at all. For example, to ignore 404s, and treat `NoMethodError`s as critical bugs you can use the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comma issues:
- extra comma after "to ignore 404s"
- missing comma after "critical bugs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love putting in extra commas. It's how I kept the writing center in business in college....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, it's an oxford comma though. So both usages are technically correct. I'll drop the comma for you anyway :)
Good call, much better to have these docs here. |
@brianr @jondeandres Fixed. |
@brianr @jondeandres mergeable finally |
Document exception level filters
Previously we told people to go see another document without a link. That's not very user friendly. This also makes
404
"Ctrl+F"able.