Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exception level filters #366

Merged
merged 2 commits into from
Feb 3, 2016

Conversation

Crisfole
Copy link
Contributor

Previously we told people to go see another document without a link. That's not very user friendly. This also makes 404 "Ctrl+F"able.

Previously we told people to go see another document without a link. That's not very user friendly. This also makes `404` "Ctrl+F"able.
@jondeandres
Copy link
Contributor

👍

@@ -379,7 +379,14 @@ By default, all uncaught exceptions are reported at the "error" level, except fo
- ```AbstractController::ActionNotFound```
- ```ActionController::RoutingError```

If you'd like to customize this list, see the example code in ```config/initializers/rollbar.rb```. Supported levels: "critical", "error", "warning", "info", "debug", "ignore". Set to "ignore" to cause the exception not to be reported at all.
If you'd like to customize this list, modify the example code in ```config/initializers/rollbar.rb```. Supported levels: "critical", "error", "warning", "info", "debug", "ignore". Set to "ignore" to cause the exception not to be reported at all. For example, to ignore 404s, and treat `NoMethodError`s as critical bugs you can use the following code:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comma issues:

  • extra comma after "to ignore 404s"
  • missing comma after "critical bugs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love putting in extra commas. It's how I kept the writing center in business in college....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, it's an oxford comma though. So both usages are technically correct. I'll drop the comma for you anyway :)

@brianr
Copy link
Member

brianr commented Jan 19, 2016

Good call, much better to have these docs here.

@Crisfole
Copy link
Contributor Author

@brianr @jondeandres Fixed.

@Crisfole
Copy link
Contributor Author

Crisfole commented Feb 3, 2016

@brianr @jondeandres mergeable finally

jondeandres added a commit that referenced this pull request Feb 3, 2016
@jondeandres jondeandres merged commit 2a63298 into master Feb 3, 2016
@waltjones waltjones deleted the docuement-exception-level-filters branch June 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants