Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue RequestDataExtractor#rollbar_ip so it doesn't crash. #233

Merged
merged 1 commit into from
Apr 2, 2015

Conversation

jondeandres
Copy link
Contributor

For example when a IpSpoofAttackError exception is raised.

We were having the next unexpected behavior:

  1. An attacker or some proxy configuration performs a suspicious request.
  2. In https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/remote_ip.rb#L125 is raised a IpSpoofAttackError exception..
  3. Our middleware initializes the reporting of the exception.
  4. Our user_ip extraction crashes for the same reason that the app crashed, trying to get the client ip, with a IpSpoofAttackError exception.

For example when a IpSpoofAttackError exception is raised.
brianr added a commit that referenced this pull request Apr 2, 2015
Rescue RequestDataExtractor#rollbar_ip so it doesn't crash.
@brianr brianr merged commit 21d10c9 into master Apr 2, 2015
@waltjones waltjones deleted the fix-user_ip_parsing branch June 27, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants