Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with dj_threshold > 0 causing errors not to fire in an edge case #615

Closed
rokob opened this issue Jul 28, 2017 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@rokob
Copy link
Contributor

rokob commented Jul 28, 2017

From #592:

There is still a potential for the error to not fire if https://github.com/richvorp/rollbar-gem/blob/delayed_job_failure_hook/lib/rollbar/plugins/delayed_job/plugin.rb#L48 check fails and the dj_threshold is higher than 0.

An alternative would be to make it always error with:

data = Rollbar::Delayed.build_job_data(job)
::Rollbar.scope(:request => data).error(job.last_error, :use_exception_level_filters => true) if job.last_error

instead of https://github.com/richvorp/rollbar-gem/blob/delayed_job_failure_hook/lib/rollbar/plugins/delayed_job/plugin.rb#L14

@rivkahstandig3636 rivkahstandig3636 added this to the v2.15.6 milestone Dec 27, 2017
@ArturMoczulski ArturMoczulski self-assigned this Feb 26, 2018
ArturMoczulski added a commit that referenced this issue Feb 26, 2018
…igher-than-0

GitHub Issue #615: Deal with dj_threshold > 0 causing errors not to fire in an edge case
@ArturMoczulski
Copy link
Contributor

Fixed in #692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants