Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Migrate forgeo to its own role #147

Open
DO1JLR opened this issue Feb 16, 2024 · 4 comments · May be fixed by #186
Open

[RFC] Migrate forgeo to its own role #147

DO1JLR opened this issue Feb 16, 2024 · 4 comments · May be fixed by #186
Labels
help wanted Extra attention is needed

Comments

@DO1JLR
Copy link
Member

DO1JLR commented Feb 16, 2024

Hello everyone.

As forgejo is becoming a hard fork of gitea, I'm proposing that it be moved to its own ansible role. (See forgejo news.)

What do you think about this?

I think future changes to the forgejo config could benefit from this. And since you can no longer swap the gitea binary with the forgejo binary, I don't see any advantage in keeping it in the same git project.

@adrinux
Copy link
Contributor

adrinux commented Jun 4, 2024

Having just hit another problem with Forgejo installed via this role (issue#165) I can see some sense in this.

It would certainly be possible to add logic and documentation to work around these issues and differences, but it does complicate things and will presumably get more complex as time goes by.

On the one hand I prefer the simplicity of one role per project, on the other they are still very similar. I think for the most part this comes down to your personal preference as a maintainer and whether you will still be using both Gitea and Forgejo.

(Myself, I've switched to Forgejo and no longer use Gitea, I'd be happy to see Forgejo forked to it's own role.)

@TigerP
Copy link
Contributor

TigerP commented Dec 25, 2024

I think it will be a good idea to fork this to a separate forgejo project.
I no longer use gitea and the current role works very well, but gives some confusion, because gitea is used for file/directory names in some places (/etc/gitea).

@adrinux
Copy link
Contributor

adrinux commented Jan 31, 2025

So how does a fork need to happen @DO1JLR ?

Do you want a forgejo-only role that remains a part of the l3d.git collection, alongside a gitea only role and the forgejo runner role?
Do you even want the gitea only role to remain?

I suppose what I'm asking is are you going to do the fork and accept pull requests from us, or do I need to fork the project?

(I'm working on getting my own collection of roles ready for Debian 13 release and would like to get some work done on the fork ready for that.)

@DO1JLR
Copy link
Member Author

DO1JLR commented Jan 31, 2025

I think in the near future I will create a fork of this role and embed it to the l3d.git collection as l3d.git.forgejo.

DO1JLR added a commit that referenced this issue Jan 31, 2025
@DO1JLR DO1JLR linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

3 participants