Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passcode screen can be beaten by killing the app #78

Closed
alexsorokoletov opened this issue Sep 8, 2014 · 4 comments
Closed

Passcode screen can be beaten by killing the app #78

alexsorokoletov opened this issue Sep 8, 2014 · 4 comments

Comments

@alexsorokoletov
Copy link
Contributor

Hi!
I'm using your controller and it's almost ideally matching my needs. Thank you very much for writing and sharing your work.
However I'm experiencing one problem and I was able to reproduce it on Demo solution from the repository.
Scenario is following:

  1. Enable passcode (enabled by default in Demo app)
  2. Deactivate app so it stays inactive.
  3. Wait for passcode timeout
  4. Activate app (either from task switcher or by tapping an icon) and see active lock screen
  5. Do not enter anything and just kill the app.
  6. Run the app from the icon
  7. App runs and no lock screen shown.

Please let me know how this behavior can be fixed.
Thank you

@alexsorokoletov
Copy link
Contributor Author

I was able to fix this by changing LTHPasscodeViewController :: _applicationWillResignActive
to

- (void)_applicationWillResignActive {
    if ([self _doesPasscodeExist] && !([self isCurrentlyOnScreen] && [self displayedAsLockScreen])) {
        [self _saveTimerStartTime];
    }
}

Please let me know if this fix is correct

@rolandleth
Copy link
Owner

Hello,

Any news on this fix working properly?

@alexsorokoletov
Copy link
Contributor Author

Fix is working properly.

@rolandleth
Copy link
Owner

Thanks!

rolandleth pushed a commit that referenced this issue Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants