Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening lockscreen in landscape #72

Closed
jardakotesovec opened this issue Jul 31, 2014 · 7 comments
Closed

Opening lockscreen in landscape #72

jardakotesovec opened this issue Jul 31, 2014 · 7 comments

Comments

@jardakotesovec
Copy link

This can be reproduced with demo project. Just rotate to landscape on ipad and tap on test. It will display lock screen somewhere off the screen.. and if you rotate to portrait and back.. its OK.
@rolandleth
Copy link
Owner

This isn't really necessary, given #71, right?

@jardakotesovec
Copy link
Author

Thanks a lot for quick response.

My app can be opened in portrait and landscape. For portrait orientation I have #71 issue and for landscape this one.

Interesting is that if I rotate device after lock screen is displayed it will fix both problems and generate layout correctly. So there has to be some difference when layout is generated initially and when its rotated.

Using latest ios7.

@rolandleth
Copy link
Owner

Sadly I don't really have much time in the foreseeable future. I will try, but I can't promise anything.

@mgratzer
Copy link
Contributor

I'm experiencing the same issue which the 3.4.1 tag via CocoaPods. I also checked the latest version from the master branch. The issue seems to be solved there.

@rolandleth
Copy link
Owner

Apparently I forgot to tag and create a pod for the latest changes. 3.1.5 is now live, can you try to update and let me know if the issue still exists?

@mgratzer
Copy link
Contributor

Unfortunately it didn't work with 3.1.5. Check out my pull request its solved there.

rolandleth pushed a commit that referenced this issue Aug 18, 2014
Merge pull request #75 from mgratzer/master
b517ecd 
Fixes issue #72
@rolandleth
Copy link
Owner

Awesome, thanks!

halmakey pushed a commit to halmakey/LTHPasscodeViewController that referenced this issue Oct 1, 2014
@ukikuchi
Merge commit 'db253d31faef6d958d9a0e48278df0f6491800b3' into ucustom
f11db61 
* commit 'db253d31faef6d958d9a0e48278df0f6491800b3':
  Removed redundand code logic.
  Fixed constraints for iOS 8. Fixed status bar offset for iPad and iOS 8.
  Some fixes for iOS 8.
  Moved the dismiss call before the delegate call.
  Fixes issue rolandleth#72
  Updated README. Changed frame depending on status bar visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgratzer @jardakotesovec @rolandleth