Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/523 check read auth middleware test #527

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Task/523 check read auth middleware test #527

merged 3 commits into from
Aug 4, 2020

Conversation

ywkim312
Copy link
Collaborator

No description provided.

@ywkim312 ywkim312 requested a review from sandeep-ps July 29, 2020 14:52
sandeep-ps
sandeep-ps previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR. We may need to revisit this later for improvements.

sandeep-ps
sandeep-ps approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging this. If new changes are needed, we can create follow up issues.

@sandeep-ps sandeep-ps merged commit c02d038 into develop Aug 4, 2020
@sandeep-ps sandeep-ps deleted the task/523-check-read-auth-middleware-test branch August 4, 2020 21:38
@sandeep-ps sandeep-ps linked an issue Aug 4, 2020 that may be closed by this pull request
Check readme process for auth library #523
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeep-ps sandeep-ps sandeep-ps approved these changes

Assignees

@ywkim312 ywkim312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check readme process for auth library
2 participants
@ywkim312 @sandeep-ps