1085 finalize button styles

[minump]

Description

Button styles changed to match zeplin design.
Used button tag with onclick function instead of anchor "a" tags.
Updated "Contribute +" button in topnav. Updated login/logout buttons. Updated buttons in contribution_details page.

Fixes #1085

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

• Immediately
• Within a week
• When possible

Type of changes

Please select a relevant option:

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

• I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
• I have updated the CHANGELOG.
• I have read the Contributor Guidelines.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My change requires updating the documentation.
• I have made necessary changes to the documentation.
• I have added tests related to my changes.
• My changes generate no new warnings.
• New and existing unit tests pass locally with my changes.
• Any dependent changes have been merged and published in downstream modules.

---

[sandeep-ps]

It's good that you could change the anchor elements back to the button elements. Thanks.

[sandeep-ps]

The focus states of Contribute+ and Save buttons look slightly off. The rest looks good to me. We might be waiting for Contribute+ icon for the focus style, but if you could update just the border, I think it'll be good. Thanks.

[minump]

Updated focus styles.

Ready for review @sandeep-ps

[sandeep-ps]

Thanks for fixing the previous items. I discovered a couple more things when re-testing this:

1. Focus styles of these buttons need to be updated. On click, the styles don't match the design.

2. The dual line still appears when clicking on the login, logout, and contribute buttons. You can see this by clicking the button and holding onto it. Please update this.

I couldn't find any other issues. Thanks.

[minump]

Thanks for fixing the previous items. I discovered a couple more things when re-testing this:

1. Focus styles of these buttons need to be updated. On click, the styles don't match the design.

2. The dual line still appears when clicking on the login, logout, and contribute buttons. You can see this by clicking the button and holding onto it. Please update this.
   I couldn't find any other issues. Thanks.

1. Updated buttons styles for "Show All" "Capabilities" and "Talents"
2. Not able to find a solution for this. Tried multiple stylings such as

outline:none;
-moz-outline-style: none;
   -webkit-appearance: none;
   -moz-box-shadow: none;
   -webkit-box-shadow: none;
box-shadow:none;

None seems to work.

[minump]

Thanks for fixing the previous items. I discovered a couple more things when re-testing this:

1. Focus styles of these buttons need to be updated. On click, the styles don't match the design.

2. The dual line still appears when clicking on the login, logout, and contribute buttons. You can see this by clicking the button and holding onto it. Please update this.
   I couldn't find any other issues. Thanks.

1. Updated buttons styles for "Show All" "Capabilities" and "Talents"
2. Not able to find a solution for this. Tried multiple stylings such as

outline:none;
-moz-outline-style: none;
   -webkit-appearance: none;
   -moz-box-shadow: none;
   -webkit-box-shadow: none;
box-shadow:none;

None seems to work.

2. Inline style worked. Added inline "style=outline:none" for the Contribute and Login/logout buttons.

[minump]

Updated code according to feedback. Ready for review. @sandeep-ps

[sandeep-ps]

The changes look good to me. Approving. Thanks.

[minump]

merging to develop