Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beforeProgramDispose event #844

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Add beforeProgramDispose event #844

merged 3 commits into from
Jul 14, 2023

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Jul 14, 2023

Adding this event to give plugins a chance for clean up, even in the event of failure (especially in the event of failure)

TwitchBronBron
TwitchBronBron requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a small tweak and then this is good. :)

src/interfaces.ts Outdated Show resolved Hide resolved
@iBicha iBicha requested a review from TwitchBronBron July 14, 2023 15:48
@TwitchBronBron TwitchBronBron merged commit 886bb76 into rokucommunity:master Jul 14, 2023
@iBicha iBicha mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iBicha @TwitchBronBron