Adds Function Call Type Validation #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
added a commit
that referenced
this pull request
Jul 17, 2023
* BinaryExpression returns runtime type of lhs and rhs * Added symbolTable type check for binary expressions * Added unary expression getType() * Deal with compound assignments as well * White space change * Added pne more test * More tests * Added function call validation (#839) * Refactor of hover processing, using SymbolTables and enableTypeValidation (#828) * Refactor of hover processing, using SymbolTables and enableTypeValidation * build fix * Uses SymbolTable and TypeChains for hover details * Build/lint fixes * Fix failing tests (caused by having wrong types!) --------- Co-authored-by: Bronley Plumb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Function Call Type Validation when
enableTypeValidationistrueScopeValidator.validateFunctionCalls()is called whenenableTypeValidationistrueExpression.getType()to get the types of a function's argumentsBscType.isTypeCompatible()methodsenableTypeValidationistrueparameter count mismatches are also handled in new method instead of inScope.tsScopeValidator.spec.ts