Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic for passing more than 5 arguments to a callFunc #765

Merged
merged 6 commits into from
Jan 6, 2023
Merged

Add diagnostic for passing more than 5 arguments to a callFunc #765

merged 6 commits into from
Jan 6, 2023

Conversation

iObject
Copy link
Collaborator

@iObject iObject commented Jan 6, 2023

Passing more than 5 arguments to a callFunc method will crash the app.
Adds a diagnostic message if more than 5 arguments are passed.

@iObject iObject requested a review from TwitchBronBron January 6, 2023 17:08
@iObject iObject linked an issue Jan 6, 2023 that may be closed by this pull request
add a warning if callfunc/@ is called with more than 5 parameters #760
Closed
TwitchBronBron
TwitchBronBron requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One change, we've been naming callfunc variables with a lowercase f. TokenKind.Callfunc, CallfuncExpression, so these changes should align with that.

src/DiagnosticMessages.ts Outdated Show resolved Hide resolved
src/Scope.spec.ts Outdated Show resolved Hide resolved
src/Scope.spec.ts Outdated Show resolved Hide resolved
src/Scope.spec.ts Outdated Show resolved Hide resolved
src/bscPlugin/validation/BrsFileValidator.ts Outdated Show resolved Hide resolved
iObject and others added 4 commits January 6, 2023 14:00
@iObject @TwitchBronBron
Update src/DiagnosticMessages.ts
42b306e 
Co-authored-by: Bronley Plumb <[email protected]>
@iObject @TwitchBronBron
Update src/Scope.spec.ts
9b3a8b8 
Co-authored-by: Bronley Plumb <[email protected]>
@iObject @TwitchBronBron
Update src/Scope.spec.ts
8c2c270 
Co-authored-by: Bronley Plumb <[email protected]>
@iObject @TwitchBronBron
Apply suggestions from code review
30ef551 
Co-authored-by: Bronley Plumb <[email protected]>
@iObject iObject requested a review from TwitchBronBron January 6, 2023 19:05
@TwitchBronBron TwitchBronBron merged commit f295226 into master Jan 6, 2023
@TwitchBronBron TwitchBronBron deleted the 760-add-a-warning-if-callfunc-is-called-with-more-than-5-parameters branch January 6, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a warning if callfunc/@ is called with more than 5 parameters
2 participants
@iObject @TwitchBronBron