Performance boost: better function sorting during validation #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating scopes, we collect all the callable functions, and then sort them by file and function name so that the diagnostics appear in the same order every time. However, it uses
localeCompareseveral times, which seems to be very slow. Since it's only about providing consistency, this doesn't need to be locale aware or overly precise.This PR refactors the sorting function to use native string sorting instead, yielding slightly better performance.
Roku-GooglePhotos:
Jellyfin-roku:
An internal Fubo app:
