Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program file improvements #506

Merged
merged 3 commits into from
Feb 7, 2022
Merged

program file improvements #506

merged 3 commits into from
Feb 7, 2022

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Feb 4, 2022

  • Improves program.getFile() to support absolute and relative paths. This more closely aligns with the v1 implementation (excluding support currently for having pkg:/ prefixes for pkgPath like v1 has);
  • deprecates getFileByPathAbsolute and getFileByPkgPath in favor of using getFile for both. (they still work, but typescript will show them in strikethrough)
    image
  • deprecates getFilesByPkgPath in favor of `getFiles (same point as above)
  • internal Program assignFile and unassignFile methods to clean up that logic (aligns with v1 implementation).
  • adds helper getFirstScopeForFile function to find the first scope for a file
  • moves FileLink interface into interfaces since it's not really a Program-specific interface.

@TwitchBronBron TwitchBronBron merged commit 56f4408 into master Feb 7, 2022
@TwitchBronBron TwitchBronBron deleted the file-add-improvements branch February 7, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant