Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire plugin events for getTranspiledFile. Add new event properties #502

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

TwitchBronBron
Copy link
Member

  • The "preview transpiled code" feature in vscode utilizes the getTranspiledFileContents function. However, plugin-related changes were not showing. This resolves that issue.
  • adds code, map, typedef properties to the afterFileTranspile event to allow plugins to manually tweak the output code (at their own risk).
  • mostly unrelated: return a reference to the plugin in the add, addFirst, and remove methods of the PluginInterface class.

* Internal function used to transpile files.
* This does not write anything to the file system
*/
private _getTranspiledFileContents(file: BscFile, outputPath?: string): FileTranspileResult {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I should come up with a better name for this? I don't like the underscore. I don't want to use the word "internal" either though.

@TwitchBronBron TwitchBronBron merged commit 7323ed5 into master Feb 2, 2022
@TwitchBronBron TwitchBronBron deleted the transpile-event-tweaks branch February 2, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants