Remove nested index files #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Jan 25, 2022
| @@ -8,8 +8,18 @@ export { Watcher } from './Watcher'; | |||
| export * from './interfaces'; | |||
| export * from './LanguageServer'; | |||
| export * from './XmlScope'; | |||
| export * from './lexer'; | |||
There was a problem hiding this comment.
All the imports from these removed lines were expanded out to their individual file exports. This ensures that our "public" api hasn't changed. One caveat, if plugin authors doing things like import { createVisitor } from 'brighterscript/astUtils' then this is technically a breaking change. However, since we were already exporting those directly from src/index.ts`, I'd argue they were not using our library properly.
Thoughts?
chrisdp
approved these changes
Jan 25, 2022
livecano
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having export barrels regularly causes debugging issues within this project, because ts-node doesn't handle circular dependencies well, and sometimes neither does typescript.
src/index.tsfile which is used by external consumers.