Add Enum functionality #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * adds validation for enums * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * changes namespace.enumStatements to map * changes namespace.enumStatements to map * fixes broken imports * uses visitor to ascertain dotted get statements * fix circular ref issues. * clean up some tests Co-authored-by: Bronley Plumb <[email protected]>
* adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * adds validation for enums * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * changes namespace.enumStatements to map * changes namespace.enumStatements to map * fixes broken imports * uses visitor to ascertain dotted get statements * fix circular ref issues. * Expression tracking during parse. * Partial support for re-calculating `references.expressions` * Capture rest of missing expressions. * Fix lint issues. * integrate with `parser.references.expressions` * Remove unnecessary eslint disable comment * Clean up enum tests * clean up some tests Co-authored-by: Bronley Plumb <[email protected]>
Add new event properties
Move enum tests into Enum.spec.ts
TwitchBronBron
force-pushed
the
feat/enum
branch
from
a12d835 to
09a0d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #299
adds support for
enumstatements. This is still a work-in-progress.enum validations are performed in the BscPlugin in the
onFileValidateevent.lexer support
parser support
validations
transpile