Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plugins relatively to the project #242

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Load plugins relatively to the project #242

merged 3 commits into from
Nov 16, 2020

Conversation

elsassph
Copy link
Contributor

When running through VS Code extension, plugins were loaded relatively to the extension, not the project.

@TwitchBronBron
Copy link
Member

Looks good. One thing: could you add a few unit tests where you pass in a different cwd through options?

@elsassph
Copy link
Contributor Author

Done @TwitchBronBron
Though I can't test loading a plugin as npm module yet.

@TwitchBronBron TwitchBronBron merged commit 1b8280f into rokucommunity:master Nov 16, 2020
@elsassph elsassph deleted the fix/plugin-loader branch February 3, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron Awaiting requested review from TwitchBronBron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsassph @TwitchBronBron