New statement namespace bugfix #208

TwitchBronBron · 2020-10-12T01:54:48Z

Fixes some bugs related to constructing new BrighterScript classes.

Notable changes:

fixed bug that wouldn't find the correct root-level class when calling new from within a namespace (fixes new keyword defaults to calling namespace #203)
fixed bug that was not adding an omitted namespace to a class whenever that class resides in the same namespace as the new statement.

TwitchBronBron · 2020-10-12T01:55:01Z

src/validators/ClassValidator.ts

@@ -35,7 +35,12 @@ export class BsClassValidator {
     */
    private getClassByName(className: string, namespaceName?: string) {
        let fullName = util.getFulllyQualifiedClassName(className, namespaceName);
-        return this.classes[fullName.toLowerCase()];


TwitchBronBron added 2 commits October 11, 2020 21:46

Fix transpile for namespaced class constructors

f075612

Fix class finding bug during validation

bdba4e2

TwitchBronBron commented Oct 12, 2020

View reviewed changes

Merge branch 'master' into new-statement-namespace-bugfix

6594ba5

TwitchBronBron merged commit 1a50d0a into master Oct 12, 2020

TwitchBronBron deleted the new-statement-namespace-bugfix branch October 12, 2020 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New statement namespace bugfix #208

New statement namespace bugfix #208

TwitchBronBron commented Oct 12, 2020

TwitchBronBron Oct 12, 2020

New statement namespace bugfix #208

New statement namespace bugfix #208

Conversation

TwitchBronBron commented Oct 12, 2020

TwitchBronBron Oct 12, 2020

Choose a reason for hiding this comment