-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Callfunc Completion and Validation #1352
Adds Callfunc Completion and Validation #1352
Conversation
…re built in types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it seems to be working fairly well. I've added a few comments for some bugs I found. Looking forward to testing it again!
Hey there! I just built a new temporary npm package based on 942025f. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250103190224.tgz |
Hey there! I just built a new temporary npm package based on 3d2e4f5. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250104221946.tgz |
Hey there! I just built a new temporary npm package based on d20aee5. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250106142632.tgz |
Hey there! I just built a new temporary npm package based on 0d6e1b4. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250108140338.tgz |
Hey there! I just built a new temporary npm package based on 05a5583. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250114181913.tgz |
Hey there! I just built a new temporary npm package based on f0626ca. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250114194334.tgz |
Hey there! I just built a new temporary npm package based on 4fc8688. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-1.0.0-alpha.41-callfunc-completion-and-validation.20250114195635.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! I'm pumped about this feature, and it works great in the projects I've tested it in. Nice work.
Gives
callFunc
a whole lotta love!@.
where ALL possible callfuncs would appear. This was a result of the parser having an exception on incomplete@.
invocations@.
callfunc invocationsCallfunc
and@.
invocations are used to set types in assignmentscallfunc
and@.
While I was it, I also added validation and return typing for
<component>.createChild()
Additional validation enhancements:
typecast
statements when setting up file segments for revalidationTODO:
roSGNode
To be honest, I think that if we properly re-build the Component type when a member file changes, that would fix both problems.
Also fixes #1309