Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed adding invalid as arg to empty callfunc invocations by default #1043

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Changed adding invalid as arg to empty callfunc invocations by default #1043

merged 3 commits into from
Jan 31, 2024

Conversation

markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented Jan 30, 2024 •
edited
Loading

New bsconfig.json option:

        "legacyCallfuncHandling": {
            "description": "Legacy RokuOS versions required at least a single argument in callfunc() invocations. Previous brighterscript versions handled this by inserting invalid as an argument when no other args are present. This is not necessary in modern RokuOS versions.",
            "type": "boolean",
            "default": false
        }

addresses #1018

@markwpearce markwpearce added this to the v1.0.0 milestone Jan 30, 2024
TwitchBronBron
TwitchBronBron requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small tweak to the wording and then this is good to go!

bsconfig.schema.json Outdated Show resolved Hide resolved
src/BsConfig.ts Outdated Show resolved Hide resolved
markwpearce and others added 2 commits January 31, 2024 10:23
@markwpearce @TwitchBronBron
Update src/BsConfig.ts
d601c19 
Co-authored-by: Bronley Plumb <[email protected]>
@markwpearce @TwitchBronBron
Update bsconfig.schema.json
06df98e 
Co-authored-by: Bronley Plumb <[email protected]>
@markwpearce markwpearce merged commit 5e2c6ce into release-0.66.0 Jan 31, 2024
6 checks passed
@markwpearce markwpearce deleted the do_not_transpile_invalid_in_callfunc branch January 31, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markwpearce @TwitchBronBron