Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Diagnostics for Member Accessibility #1004

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Adds Diagnostics for Member Accessibility #1004

merged 5 commits into from
Jan 9, 2024

Conversation

markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented Jan 9, 2024 •
edited by TwitchBronBron
Loading

  • Adds diagnostics for setting unknown fields of classes

image
image

  • Adds diagnostics for accessing private or protected class members when you shouldn't have access to them.

Private members are available in the class that defined them
Protected members are available in the class that defined them, and all sub classes.

out.mp4

Solves #966
Solves #967
Solves #918

@markwpearce markwpearce changed the base branch from master to release-0.66.0 January 9, 2024 17:03
TwitchBronBron
TwitchBronBron approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work.

@markwpearce markwpearce merged commit 8d6c3ac into release-0.66.0 Jan 9, 2024
6 checks passed
@markwpearce markwpearce deleted the flag_bad_assignments branch January 9, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markwpearce @TwitchBronBron