Review comments, gfoidl dotnet#1

- change local variables from ushort to int
rokonec · Nov 10, 2020 · 224f1bc · 224f1bc
1 parent 828c1d6
commit 224f1bc
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/Huffman.cs b/src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/Huffman.cs
@@ -422,10 +422,9 @@ public static int Decode(ReadOnlySpan<byte> src, ref byte[] dstArray)
             int lookupTableIndex = 0;
             int lookupIndex;
 
-            ushort acc = 0;
+            uint acc = 0;
             int bitsInAcc = 0;
 
-
             int i = 0;
             int j = 0;
             while (i < src.Length)
@@ -440,7 +439,7 @@ public static int Decode(ReadOnlySpan<byte> src, ref byte[] dstArray)
                 {
                     lookupIndex = (byte)(acc >> (bitsInAcc - 8));
 
-                    ushort lookupValue = decodingTree[(lookupTableIndex << 8) + lookupIndex];
+                    int lookupValue = decodingTree[(lookupTableIndex << 8) + lookupIndex];
 
                     if (lookupValue < 0x80_00)
                     {
@@ -499,7 +498,7 @@ public static int Decode(ReadOnlySpan<byte> src, ref byte[] dstArray)
                 // Lookup index has to be 8 bits aligned to MSB
                 lookupIndex = (byte)(acc << (8 - bitsInAcc));
 
-                ushort lookupValue = decodingTree[(lookupTableIndex << 8) + lookupIndex];
+                int lookupValue = decodingTree[(lookupTableIndex << 8) + lookupIndex];
 
                 if (lookupValue < 0x80_00)
                 {