bug fixes for css eslint rule (vercel#14202)

- ignores the link tags which do not have literal href e.g. `<link rel="stylesheet" href={props.href} />`
rokinsky · Jul 11, 2020 · 49f9c02 · 49f9c02
1 parent 1e26f6b
commit 49f9c02
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/eslint-plugin-next/lib/rules/no-css-tags.js b/packages/eslint-plugin-next/lib/rules/no-css-tags.js
@@ -18,7 +18,9 @@ module.exports = function (context) {
         ) &&
         attributes.find(
           (attr) =>
-            attr.name.name === 'href' && !/^https?/.test(attr.value.value)
+            attr.name.name === 'href' &&
+            attr.value.type === 'Literal' &&
+            !/^https?/.test(attr.value.value)
         )
       ) {
         context.report({

diff --git a/test/eslint-plugin-next/no-css-tags.test.js b/test/eslint-plugin-next/no-css-tags.test.js
@@ -50,6 +50,18 @@ ruleTester.run('no-css-tags', rule, {
           );
         }
     }`,
+
+    `import {Head} from 'next/document';
+      export class Blah extends Head {
+        render(props) {
+          return (
+            <div>
+              <h1>Hello title</h1>
+              <link rel="stylesheet" {...props} />
+            </div>
+          );
+        }
+    }`,
   ],
 
   invalid: [