Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added italics and bold styling markdown syntax features #24

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

gulyapulya
Copy link
Contributor

@gulyapulya gulyapulya commented Sep 28, 2022

Fixes #23

My intention was to implement additional syntax features for the markdown files such as italics and bold. They should be transformed into html properly and right now they are not.

My solution is to replace all markdown styling symbols with the corresponding html elements. In markdown, *sample text* or _sample text_ are used to display the sample text in italics and **sample text** or __sample text__ are used to display the sample text in bold. Therefore, for html, they have to be transformed into <i></i> and <b></b> elements respectively. I integrated my code into the existing markdown module. I combined it with the links replacement part as it uses the same technique.

I also added new lines to the testing markdown files to check my features.

@gulyapulya
Copy link
Contributor Author

@rokaicker Could you please review my pull request?

Copy link
Owner

@rokaicker rokaicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gulyapulya, the changes look good!

I was wondering, could you add a section in the "Overview" section documenting the capabilities of the markdown parser? (like maybe say the program is able to parse markdown files and properly parse, italicized, bolded, heading text, etc.)?

@gulyapulya
Copy link
Contributor Author

@rokaicker, yes, sure!

The overview now contains information about the supported markdown styling features.

@rokaicker rokaicker merged commit 4067f6d into rokaicker:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown syntax features for Italics and Bold
2 participants