-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paths with spaces in source_files parameter does not work #84
Comments
Thanks @xsaero00 for the issue report, I will have a look |
I have done some preliminary investigation and the challenge is that the default separator is space. I have an idea for a solution, where based on contents of the I hope to be able to address this during this week (Easter holiday). The issue seem to be in |
This is first shot at a fix of the issue reported in #84. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked. Now it should work for both file paths without spaces and file paths with spaces, which however require uniform quoting using either ' (single quotes) or " (double quotes)
Hi @xsaero00 I believe I have made fix, I expect to push it live when I have done some more testing. |
…uoting (#90) * This is first shot at a fix of the issue reported in #86. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked. Now it should work for both file paths without spaces and file paths with spaces, which however require uniform quoting using either ' (single quotes) or " (double quotes) * amend! This is first shot at a fix of the issue reported in #84. I believe file paths without space has been working as a conincidence since the splitting has not been working at all, but treating the list of file names as a single string also worked. Now it should work for both file paths without spaces and file paths with spaces, which however require uniform quoting using either ' (single quotes) or " (double quotes) * Bumped version in examples for the upcoming bug fix release * Updated the documentation to support the bug fix addressing issue #84 * Minor correction to Dockerfile, was executing as sh, but was using Bash script
Hi @xsaero00 There was a minor mishap with the 0.23.1 release, so a 0.23.2 was released. You should evaluate that particular release - sorry about any inconvenience |
Thanks @jonasbn. I'll be updating to the latest version of the action. |
When files with spaces in paths are supplied to
source_files
parameter the action does not work as expected.Partial log:
PS. Escaping spaces with backslash does not help.
The text was updated successfully, but these errors were encountered: