Skip to content

Commit

Permalink
netdev-dummy: Add support and test for TSO.
Browse files Browse the repository at this point in the history
Test that netdev-dummy is able to send and receive segment offloaded
packets.

Acked-by: Simon Horman <[email protected]>
Signed-off-by: Mike Pattrick <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
  • Loading branch information
mkp-rh authored and igsilya committed Jan 17, 2024
1 parent 76e2f20 commit 0edfe05
Show file tree
Hide file tree
Showing 2 changed files with 103 additions and 1 deletion.
30 changes: 29 additions & 1 deletion lib/netdev-dummy.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "unaligned.h"
#include "timeval.h"
#include "unixctl.h"
#include "userspace-tso.h"
#include "reconnect.h"

VLOG_DEFINE_THIS_MODULE(netdev_dummy);
Expand Down Expand Up @@ -152,6 +153,8 @@ struct netdev_dummy {
bool ol_ip_csum OVS_GUARDED;
/* Flag RX packet with good csum. */
bool ol_ip_csum_set_good OVS_GUARDED;
/* Set the segment size for netdev TSO support. */
int ol_tso_segsz OVS_GUARDED;
};

/* Max 'recv_queue_len' in struct netdev_dummy. */
Expand Down Expand Up @@ -806,6 +809,10 @@ netdev_dummy_get_config(const struct netdev *dev, struct smap *args)
smap_add_format(args, "ol_ip_csum_set_good", "%s", "true");
}

if (netdev->ol_tso_segsz && userspace_tso_enabled()) {
smap_add_format(args, "ol_tso_segsz", "%d", netdev->ol_tso_segsz);
}

/* 'dummy-pmd' specific config. */
if (!netdev_is_pmd(dev)) {
goto exit;
Expand Down Expand Up @@ -937,6 +944,14 @@ netdev_dummy_set_config(struct netdev *netdev_, const struct smap *args,
netdev_->ol_flags |= NETDEV_TX_OFFLOAD_IPV4_CKSUM;
}

if (userspace_tso_enabled()) {
netdev->ol_tso_segsz = smap_get_int(args, "ol_tso_segsz", 0);
if (netdev->ol_tso_segsz) {
netdev_->ol_flags |= (NETDEV_TX_OFFLOAD_TCP_TSO
| NETDEV_TX_OFFLOAD_TCP_CKSUM);
}
}

netdev_change_seq_changed(netdev_);

/* 'dummy-pmd' specific config. */
Expand Down Expand Up @@ -1119,6 +1134,13 @@ netdev_dummy_rxq_recv(struct netdev_rxq *rxq_, struct dp_packet_batch *batch,
/* The netdev hardware sets the flag when the packet has good csum. */
dp_packet_ol_set_ip_csum_good(packet);
}

if (userspace_tso_enabled() && netdev->ol_tso_segsz) {
dp_packet_set_tso_segsz(packet, netdev->ol_tso_segsz);
dp_packet_hwol_set_tcp_seg(packet);
dp_packet_hwol_set_csum_tcp(packet);
}

ovs_mutex_unlock(&netdev->mutex);

dp_packet_batch_init_packet(batch, packet);
Expand Down Expand Up @@ -1174,6 +1196,12 @@ netdev_dummy_send(struct netdev *netdev, int qid,
DP_PACKET_BATCH_FOR_EACH(i, packet, batch) {
const void *buffer = dp_packet_data(packet);
size_t size = dp_packet_size(packet);
bool is_tso;

ovs_mutex_lock(&dev->mutex);
is_tso = userspace_tso_enabled() && dev->ol_tso_segsz &&
dp_packet_hwol_is_tso(packet);
ovs_mutex_unlock(&dev->mutex);

if (!dp_packet_is_eth(packet)) {
error = EPFNOSUPPORT;
Expand All @@ -1194,7 +1222,7 @@ netdev_dummy_send(struct netdev *netdev, int qid,
if (eth->eth_type == htons(ETH_TYPE_VLAN)) {
max_size += VLAN_HEADER_LEN;
}
if (size > max_size) {
if (size > max_size && !is_tso) {
error = EMSGSIZE;
break;
}
Expand Down
74 changes: 74 additions & 0 deletions tests/dpif-netdev.at
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,80 @@ AT_CHECK_UNQUOTED([tail -n 1 p2.pcap.txt], [0], [${good_expected}
OVS_VSWITCHD_STOP
AT_CLEANUP

AT_SETUP([userspace offload - tso])
OVS_VSWITCHD_START(
[set Open_vSwitch . other_config:userspace-tso-enable=true -- \
add-br br1 -- set bridge br1 datapath-type=dummy -- \
add-port br1 p1 -- \
set Interface p1 type=dummy -- \
add-port br1 p2 -- \
set Interface p2 type=dummy])

dnl Simple passthrough rule.
AT_CHECK([ovs-ofctl add-flow br1 in_port=p1,actions=output:p2])

flow_s="in_port(1),eth(src=8a:bf:7e:2f:05:84,dst=0a:8f:39:4f:e0:73),eth_type(0x0800), \
ipv4(src=192.168.123.2,dst=192.168.123.1,proto=6,tos=1,ttl=64,frag=no), \
tcp(src=54392,dst=5201),tcp_flags(ack)"

flow_s_v6="in_port(1),eth(src=8a:bf:7e:2f:05:84,dst=0a:8f:39:4f:e0:73),eth_type(0x86dd), \
ipv6(src=2001:cafe::88,dst=2001:cafe::92,proto=6), \
tcp(src=54392,dst=5201),tcp_flags(ack)"

dnl Send from tso to no-tso.
AT_CHECK([ovs-vsctl set Interface p2 options:tx_pcap=p2.pcap -- \
set Interface p1 options:ol_ip_csum=true -- \
set Interface p1 options:ol_ip_csum_set_good=false -- \
set Interface p1 options:ol_tso_segsz=500])

AT_CHECK([ovs-appctl netdev-dummy/receive p1 "${flow_s}" --len 2054])
AT_CHECK([ovs-appctl netdev-dummy/receive p1 "${flow_s_v6}" --len 2074])

dnl Send from tso to tso.
AT_CHECK([ovs-vsctl set Interface p2 options:ol_ip_csum=true -- \
set Interface p2 options:ol_ip_csum_set_good=false -- \
set Interface p2 options:ol_tso_segsz=500])

AT_CHECK([ovs-appctl netdev-dummy/receive p1 "${flow_s}" --len 2054])
AT_CHECK([ovs-appctl netdev-dummy/receive p1 "${flow_s_v6}" --len 2074])

dnl Check that first we have:
dnl - 4x IPv4 500 byte payloads
dnl - 4x IPv6 500 byte payloads
dnl - one IPv4 2000 byte payload, and
dnl - one IPv6 2000 byte payload
zero500=$(printf '0%.0s' $(seq 1000))
AT_CHECK_UNQUOTED([ovs-pcap p2.pcap], [0], [dnl
[0a8f394fe0738abf7e2f058408004501021c0000000040060187c0a87b02c0a87b01]dnl
[d47814510000000000000000501000004dc20000${zero500}]
[0a8f394fe0738abf7e2f058408004501021c0001000040060186c0a87b02c0a87b01]dnl
[d4781451000001f400000000501000004bce0000${zero500}]
[0a8f394fe0738abf7e2f058408004501021c0002000040060185c0a87b02c0a87b01]dnl
[d4781451000003e8000000005010000049da0000${zero500}]
[0a8f394fe0738abf7e2f058408004501021c0003000040060184c0a87b02c0a87b01]dnl
[d4781451000005dc000000005010000047e60000${zero500}]
[0a8f394fe0738abf7e2f058486dd60000000020806002001cafe0000000000000000000000]dnl
[882001cafe000000000000000000000092d4781451000000000000000050100000edfd0000]dnl
[${zero500}]
[0a8f394fe0738abf7e2f058486dd60000000020806002001cafe0000000000000000000000]dnl
[882001cafe000000000000000000000092d4781451000001f40000000050100000ec090000]dnl
[${zero500}]
[0a8f394fe0738abf7e2f058486dd60000000020806002001cafe0000000000000000000000]dnl
[882001cafe000000000000000000000092d4781451000003e80000000050100000ea150000]dnl
[${zero500}]
[0a8f394fe0738abf7e2f058486dd60000000020806002001cafe0000000000000000000000]dnl
[882001cafe000000000000000000000092d4781451000005dc0000000050100000e8210000]dnl
[${zero500}]
[0a8f394fe0738abf7e2f05840800450107f8000000004006fbaac0a87b02c0a87b01]dnl
[d478145100000000000000005010000047e60000${zero500}${zero500}${zero500}${zero500}]
[0a8f394fe0738abf7e2f058486dd6000000007e406002001cafe0000000000000000000000]dnl
[882001cafe000000000000000000000092d4781451000000000000000050100000e8210000]dnl
[${zero500}${zero500}${zero500}${zero500}]
])

OVS_VSWITCHD_STOP
AT_CLEANUP

AT_SETUP([dpif-netdev - revalidators handle dp modification fail correctly])
OVS_VSWITCHD_START(
[add-port br0 p1 \
Expand Down

0 comments on commit 0edfe05

Please sign in to comment.