-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useThemeContext
and switch to the new useColorMode
added in Canary.
#117
Conversation
This fixes issue #116 by applying the fix for the breaking change in the latest canary build.
|
Fixes #117 |
I will also update the dependencies and then merge this, currently it breaks the build. Thanks for the PR |
Hi, I'm actually just looking into using this tool and I'm getting this error - when do you think it can be looked at to be merged? We need to serve a lot of OpenAPI docs and this looks like a good tool :) |
This it's so good |
sorry for the annoyance, maybe we should provide something to make it retrocompatible? But we'll keep using the theme-common package in the future for such things and use the theme mostly for regular React components |
Merging with failed build, fixing build in this follow up PR: #119 |
Release is up: #122 |
@slorber Might be nice, but I'm thinking if we can better declare this dependency b/w plugins<->docusaurus via peerDependencies? I don't currently add Docusaurus as a peer dependency, should I add it? I'm not sure how that would look like |
@rohit-gohri now you should add this |
Closes #116