testscript: add ${/} as a companion to ${:} #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${:} expands to os.PathListSeparator; now ${/} expands to
os.PathSeparator.
It's useful to skip windows-vs-unixy conditions, like the ones that we
simplified in exec_path_change with HOME and PATH.
It's also useful so that 'cmpenv stdout stdout.golden' can easily
support output which contains relative file paths.
While at it, make the stdin and exec_path_change scripts work on Wine
(i.e. vanilla Windows), which has neither Go nor coreutils installed.
|
FWIW, in the That admittedly does not work for |
|
Yep, this is precisely to support cmpenv. There is no way to compare stdout to a |
fhs
added a commit
to fhs/go-internal
that referenced
this pull request
Nov 18, 2020
Plan 9 environment variables names can't have slash in them. Removing this is not a big loss considering it's not available in `cmd/go` testscripts and it's also not documented. Update rogpeppe#90
fhs
added a commit
to fhs/go-internal
that referenced
this pull request
Nov 22, 2020
We're changing the name because ${/} doesn't work on Plan 9.
Plan 9 environment variables are stored as files in `/env`,
so they can't have slash in them.
Update rogpeppe#90
fhs
added a commit
to fhs/go-internal
that referenced
this pull request
Nov 22, 2020
We're changing the name because ${/} doesn't work on Plan 9.
Plan 9 environment variables are stored as files in `/env`,
so they can't have slash in them.
Update rogpeppe#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${:} expands to os.PathListSeparator; now ${/} expands to
os.PathSeparator.
It's useful to skip windows-vs-unixy conditions, like the ones that we
simplified in exec_path_change with HOME and PATH.
It's also useful so that 'cmpenv stdout stdout.golden' can easily
support output which contains relative file paths.
While at it, make the stdin and exec_path_change scripts work on Wine
(i.e. vanilla Windows), which has neither Go nor coreutils installed.