Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modfile: add tests for AddReplace and DropReplace #72

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented May 27, 2019

PR adds a few tests for modfile's AddReplace and DropReplace functions.

@dmitris
Copy link
Contributor Author

dmitris commented Jul 15, 2019

@rogpeppe - does the change look ok to you?

@rogpeppe
Copy link
Owner

Thanks very much for suggesting these changes. In principle I am in favour, but I also wish to keep this package as close to the original modfile package as possible. How about adding the new tests in a separate file, say replace_test.go? Then we can more easily update the rest of the source files by simply copying them.

@dmitris
Copy link
Contributor Author

dmitris commented Jul 18, 2019

@rogpeppe - that's a good idea, I put the new tests in modfile/replace_test.go.

@rogpeppe
Copy link
Owner

LGTM, thanks!

@rogpeppe rogpeppe merged commit 3670dca into rogpeppe:master Jul 18, 2019
@dmitris dmitris deleted the replace-tests branch July 18, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants