Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept ! for negation without requiring a space #215

Closed
wants to merge 2 commits into from

Conversation

ldemailly
Copy link

Fixes #190

@mvdan
Copy link
Collaborator

mvdan commented May 2, 2023

Sorry, but I don't think this is a good idea. The testscript syntax is simple and it should stay that way. Neither POSIX Shell nor Bash even support removing the space after !, so this doesn't bring us any closer to syntax that people are used to. I'll review Axel's PR instead.

@mvdan mvdan closed this May 2, 2023
@ldemailly
Copy link
Author

for the record, re consistency:

lines like

[!exec:false] skip

aren't

[ ! exec:false ] skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testscript: Accept !cmd (without space) or provide better error
2 participants