fix: [capricorn86#1285] Prevent contains from accessing properties of…

… undefined arguments
rofly · Mar 1, 2024 · 5051cf0 · 5051cf0
1 parent c127bc6
commit 5051cf0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/happy-dom/src/nodes/node/Node.ts b/packages/happy-dom/src/nodes/node/Node.ts
@@ -298,7 +298,10 @@ export default class Node extends EventTarget implements INode {
 	 * @param otherNode Node to test with.
 	 * @returns "true" if this node contains the other node.
 	 */
-	public contains(otherNode: INode): boolean {
+	public contains(otherNode: INode | undefined): boolean {
+		if (otherNode === undefined) {
+			return false;
+		}
 		return NodeUtility.isInclusiveAncestor(this, otherNode);
 	}
 

diff --git a/packages/happy-dom/test/nodes/node/Node.test.ts b/packages/happy-dom/test/nodes/node/Node.test.ts
@@ -328,6 +328,11 @@ describe('Node', () => {
 		it('Returns "false" if match node is null.', () => {
 			const div = document.createElement('div');
 
+			expect(div.contains(null)).toBe(false);
+		});
+		it('Returns "false" if match node is undefined.', () => {
+			const div = document.createElement('div');
+
 			expect(div.contains(null)).toBe(false);
 		});
 	});