Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seemingly needless overwrite of file bytes upon picking a file #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robholmes
Copy link

When you open a file that you don't have write permissions for, picking the file will fail, couldn't understand why as I didn't think this should be writing to the file I'm picking to read.

After digging a bit deeper I can see that upon picking a file, the code will read all file bytes and then write them to the file, effectively overwriting the original file, with the same bytes. I tried to work out if there was a reason for this behaviour, and I can't see anything, but happy to stand corrected if there's a valid reason for this.

My proposed fix for this, simply removes the calls to readAsBytes and writeAsBytes, and returns a future FileX which points to the file path, which then leaves it to the end-developer, as to whether they want to read or write to the picked file.

I've tested this on the example app, and this seems to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant