-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At least some versions of iOS 8 still need this fix #35
Comments
This may be caused by/related to flexbox issues. Can you provide a minimal test case so we can investigate further? |
I am not sure if I can. Currently I don't have access to this iPhone. So I am flying somewhat blind here. Guido On Mon, 12 Jan 2015 04:52:36 -0800
|
You problem has got nothing to do with viewport units. Upon fixing the following styles in your CSS, the boxes were placed properly:
the reason is simple If you agree with the assessment, please close this issue. |
Hmm.. it is absolute possible that my css is buggy. It is the very first time I do stuff like that. The only thing I don't understand is, if above assessment really is true, how does viewport-units-buggyfill fix this? Crappy css should be crappy css with our without viewport-units-buggyfill. And with window.viewportUnitsBuggyfill.init({force: true}); it looks like I wanted to look it. |
No clue. For some reason WebKit says the footer is Issue #19 was the one reporting that viewport units were fixed in iOS8. Maybe @Euene, @ImBobby, @duranmla and @blowback want to have a look at the test case on their devices? Right now I feel inclined to re-enable the buggyfill on iOS8. |
I have tried the link in both iPhone 4s and iPad Air running iOS 8.1.2. I added But the calculated value is strange. The value of window, clientHeight and the element should be equal right (CMIIW)? Here's the result: iPhone 4s
|
Window | ClientHeight | Element |
---|---|---|
372px | 372px | 441px |
Landscape
Window | ClientHeight | Element |
---|---|---|
320px | 320px | 320px |
Ipad Air 768 x 1024
( device-width )
Portrait
Window | ClientHeight | Element |
---|---|---|
928px | 928px | 985px |
Landscape
Window | ClientHeight | Element |
---|---|---|
672px | 672px | 729px |
Only in iPhone landscape mode the all the heights are equal.
anyway, the viewport unit bug should be fix already. Last December, Apple did bring fix to Safari regarding video playback and I doubt they messed up with the viewport unit. |
yes, they should. At least they are on other browsers. That's what got me stumped :/ |
Very strange indeed. I have been using viewport unit in some projects, tested in iOS8 and didn't have any issue. I mean, visually the site was not broken. It turned out as expected. Should we wait for another test case? |
I have the same issue on iOS 8.1.3 on an iPhone 5 and an iPad 2. The interface (URL bar, tabs) is part of a When added to the home screen, it works well if |
I think I figured out what the "problem" is. I'm not sure if the buggyfill should do anything about this?! |
according to the specification
That means 100vw is actually full width of browser - scrollbar width and 100vh is equal to |
This issue still occurs when doing using the the embedded web browser control in an IOS app. Without the buggyfill running we see problems where the embedded keyboard control will re-size the window when an input is edited, but the elements don't redraw. It works correctly in Safari, but not in the embedded browser. If I force the buggyfill to initialize, the embedded browser then also works properly. |
Are you talking about the native keyboard, or something the host app made available? |
yeah, when the native keyboard is opened up within the app it appears to open as part of the page rather than over the top of it. Elements on the page that use VH get altered to try and fit the new height, but when the keyboard is dismissed they do not update again to the full view height. It appears to be specific to the embedded browser control as the issue does not occur in Safari on the same iPod. Right now I am working around it by using the force=true option on init when its userAgent is the iOS webkit. |
Is there a specific app this can be reproduced with? I've never experienced that behavior before…
Which is pretty much what I'm doing as well - for other reasons, but that approach is fine! |
Referring http://nicolas-hoizey.com/2015/02/viewport-height-is-taller-than-the-visible-part-of-the-document-in-some-mobile-browsers.html#march-4th-update apple says that "this issue behaves as intended". I suggest reenable support for ios 8. |
Still true in iOS 9… :-/ |
I give up on this… enabled for iOS8 and iOS9 by #67 |
Thanks! |
I have an iPhone with IOS 8:
User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 8_1_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12B440 Safari/600.1.4
With 0.5.0 which claims:
I have to use force:
window.viewportUnitsBuggyfill.init({force: true});
Else....see the difference.
The text was updated successfully, but these errors were encountered: