Fixes https://github.com/rodjek/puppet-lint/issues/249 - Variables incorrectly identified as top scope #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
added a commit
that referenced
this pull request
Aug 17, 2014
|
Thanks for the submission but I'm going to close this in favour of #293 which has more complete support (can detect when loop-local variables are referenced outside the block). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects when parser = future and we are utilising the $foo.each |$var| loops that gives us puppet-lint will throw a warning saying that we are referencing a top scope variable (when in fact we are not).
Not being a puppet-lint pro here, the change i've done seems to circumvent that issue, and i've also added a test for it