Fix illegal replacement of double quotes by single quotes

[Seldaek]

No description provided.

[rodjek]

I would say that given the style guide's opinion on quotes, the correct thing to do in this circumstance would be to reverse the quotes

exec { 'sh -c "foo"': }

[Seldaek]

@rodjek yes and no. I mean the current example is simple of course, but in more complex cases using double quotes vs single quotes can be quite a pain due to escaping of vars and all. It can make stuff quite harder to read.

The real issue right now is that it switches to single quotes but leaves the single quotes in the string intact, resulting in an invalid string like: 'sh -c 'foo''.

So I would suggest merging this for now, then either:

• patch it so it prints a warning again for those, but does not apply the broken fix (I can try and do that if my ruby allows).
• patch it so it does the fix correctly, but that might prove hard to do correctly because it relies on shell escaping rules.

[hcgrove]

As the shell command might contain code in pretty much any language, doing the fix correctly would pretty much require parsing any language (just imagine what it would take not to trash code building some code passed to eval).

I would say the only sane to do when nested quoting is found is nothing, perhaps print a warning, but please add an option to skip those.

[dalen]

I think geppetto fixes it into something like this:

exec { 'sh -c \'foo\'': }

Note that there is a issue to relax the style guideline in cases like this: http://projects.puppetlabs.com/issues/19294