Can't handle single quotes? (slurpstring)

[beaufour]

This fairly simple template breaks puppet-lint:

class test {
  $foo = 'bar'
}

If I use double quotes instead, it works.

$ /var/lib/gems/1.8/bin/puppet-lint test.pp
/var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint/plugins/check_strings.rb:13:in `slurpstring': wrong number of arguments (3 for 1) (ArgumentError)
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint/plugins/check_strings.rb:13:in `convert'
from /usr/lib/ruby/1.8/puppet/parser/lexer.rb:360:in `munge_token'
from /usr/lib/ruby/1.8/puppet/parser/lexer.rb:428:in `scan'
from /usr/lib/ruby/1.8/puppet/parser/lexer.rb:257:in `fullscan'
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint/plugin.rb:59:in `run'
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint.rb:158:in `run'
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint.rb:157:in `each'
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/../lib/puppet-lint.rb:157:in `run'
from /var/lib/gems/1.8/gems/puppet-lint-0.1.12/bin/puppet-lint:85
from /var/lib/gems/1.8/bin/puppet-lint:19:in `load'
from /var/lib/gems/1.8/bin/puppet-lint:19

$ ruby --version
ruby 1.8.7 (2010-01-10 patchlevel 249) [x86_64-linux]

$ /var/lib/gems/1.8/bin/puppet-lint --version
Puppet-lint 0.1.12

[rodjek]

I'm guessing it's because $var foo = 'bar'; isn't valid Puppet code, but if so it should be handled more gracefully. What version of Puppet are you running as well?

[beaufour]

meh, did that testcase a little too fast. Give me a sec

[beaufour]

This is actually valid, and fails with the same error:

class test {
  $foo = 'bar'
}

$ puppetd --version
0.25.4

[rodjek]

Ah, that'll be the problem. puppet-lint currently only supports Puppet >= 2.6. I'll look into how painful it'll be to add support for the legacy 0.2x releases.

[beaufour]

Ah, bah. 0.25.4 is unfortunately the version that comes with Ubuntu 10.04 LTS :(

[rodjek]

In the meantime, I highly recommend pulling some more recent packages from http://apt.puppetlabs.com :)

[rodjek]

Just pushed version 0.1.13 that supports Puppet 0.25.x. Give it a go and let me know if you run into any issues with it.

[beaufour]

It works. Thanks for the really quick fix for this!