2.3.1 - Puppet lint fails with 1.8.7-p371 and Puppet 3.8.0

[jeffmccune]

Expected behavior: Same as 2.3.0

Actual behavior:

SyntaxError: /home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/configuration.rb:53: undefined (?...) sequence: /^(?<option>\w+)=?$/
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438
/home/travis/build/acme/puppet-module-confluence/Rakefile:1:in `gem_original_require'
/home/travis/build/acme/puppet-module-confluence/Rakefile:1:in `require'
/home/travis/build/acme/puppet-module-confluence/Rakefile:1
/home/travis/.rvm/gems/ruby-1.8.7-p371/bin/ruby_executable_hooks:15
(See full trace by running task with --trace)

Using a module with a build matrix of:

---
language: ruby

rvm:
  - 1.8.7
  - 2.1.9

env:
  matrix:
    - PUPPET_GEM_VERSION="~> 3.8.0"
    - PUPPET_GEM_VERSION="~> 4"

sudo: false

# TODO: add spec tests
script: 'SPEC_OPTS="--format documentation" bundle exec rake validate lint'

matrix:
  fast_finish: true
  exclude:
    - rvm: 1.8.7
      env: PUPPET_GEM_VERSION="~> 4"
    - rvm: 2.1.9
      env: PUPPET_GEM_VERSION="~> 3.8.0"

notifications:
  email: false

[rnelson0]

This appears related to #754 which should be addressed in 2.3.2 (#755 and #758), can you confirm?

[dividehex]

AFAICK, this is not fixed with 2.3.2

Fetching puppet-lint 2.3.2
Installing puppet-lint 2.3.2

/home/travis/.rvm/rubies/ruby-1.8.7-p371/lib/ruby/site_ruby/1.8/rubygems/core_ext/kernel_require.rb:55:in `gem_original_require': /home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.2/bin/../lib/puppet-lint/configuration.rb:53: undefined (?...) sequence: /^(?<option>\w+)=?$/ (SyntaxError)
	from /home/travis/.rvm/rubies/ruby-1.8.7-p371/lib/ruby/site_ruby/1.8/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.2/bin/../lib/puppet-lint.rb:7
	from /home/travis/.rvm/rubies/ruby-1.8.7-p371/lib/ruby/site_ruby/1.8/rubygems/core_ext/kernel_require.rb:55:in `gem_original_require'
	from /home/travis/.rvm/rubies/ruby-1.8.7-p371/lib/ruby/site_ruby/1.8/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.2/bin/puppet-lint:5
	from /home/travis/.rvm/gems/ruby-1.8.7-p371/bin/puppet-lint:23:in `load'
	from /home/travis/.rvm/gems/ruby-1.8.7-p371/bin/puppet-lint:23
	from /home/travis/.rvm/gems/ruby-1.8.7-p371/bin/ruby_executable_hooks:15

[rnelson0]

Ah, I did not noticed the Ruby 1.8.7 part. Puppet 4 AIO shipped with Ruby 2.1.9 and I would suggest using that or higher to test with Puppet 4 and Ruby 1.9.0 and higher with Puppet 3. puppet-lint itself no longer tests with Ruby 1.8.7, though.

[jeffmccune]

I don't see any overlap between #754 and this issue.

[jeffmccune]

Ah, I did not noticed the Ruby 1.8.7 part. Puppet 4 AIO shipped with Ruby 2.1.9 and I would suggest using that or higher to test with Puppet 4. puppet-lint itself no longer tests with Ruby 1.8.7, though.

We're testing Puppet 3.8 with 1.8.7 and exclude Puppet 4 on 1.8.7. See the exclusions in the travis matrix for the details.

[jeffmccune]

puppet-lint itself no longer tests with Ruby 1.8.7, though.

It should be. Version 2 is documented as the last version supporting Ruby 1.8.

[rnelson0]

I see that and I'm not sure where that went awry. @rodjek will hopefully be online soon and can comment as he's more in tune with the project's direction and the changes that were removed that likely affect this issue.

[jeffmccune]

Thanks Rob, and thanks for helping out with puppet-lint. It's really nice you're putting your time and effort into maintaining tools so many of us rely on.

[rodjek]

Gah, I read it wrong and thought we'd already deprecated 1.8.7, so I removed it from the travis matrix as it was already in the allowed_failures group. I'll get a PR to restore 1.8.7 functionality going today for a 2.3.3 release.