nested ensure misdetected as not coming first.

[jamesooden]

Taking the following puppet code:

class thing {
    class {'thang':
        stuff => {
            'stuffing' => {
                ensure => 'present',
                blah   => 'bleah',
            }
        },
    }
}

And running puppet-lint against it I will get the following warning:

WARNING: ensure found on line but it's not the first attribute on line 6

Which is not true, as the ensure is embedded in the next level of the structure and at that level it is the first attribute.

[ghoneycutt]

ensure is not an attribute at all in this case as it is on the right side of the attribute assignment.

[jamesooden]

Right, and should not cause the warning to be flagged.

[benohara]

We see this for stuff relating to the mysql module, users, grants etc :(

[jeff1evesque]

@jamesooden 👍 I'm getting the same error:

• https://travis-ci.org/jeff1evesque/machine-learning/builds/82088279#L1334
• https://github.com/jeff1evesque/machine-learning/blob/2afeaa68cac8f9092687c04b34d6baf86e64a274/puppet/manifests/setup_database.pp#L14

[jeff1evesque]

I may look for alternative linters, as I find this a necessity. Otherwise, my travis will give me a nice red button on my README.md stating that puppet-lint is unable to detect ensure properly.

[ghoneycutt]

@jeff1evesque You can disable checks.

Here is an example

https://github.com/ghoneycutt/puppet-module-vim/blob/master/Rakefile#L3

[jeff1evesque]

@ghoneycutt, thank you! I will most likely consider the following disabling check syntax:

• puppet-lint --no-ensure_first_param-check path/to/file.pp

[rnelson0]

@jamesooden @benohara Can either of you link to a use of this in practical code? The example code does not make sense, as ensure should be a quoted word where it's being used as a hash key.

[jamesooden]

Not anymore; I don't work for that company any more. I assure you it was
in practical code. Sorry the example doesn't make sense to you...James

On Sat, Jun 25, 2016 at 12:38 AM, Rob Nelson [email protected]
wrote:

@jamesooden https://github.com/jamesooden @benohara
https://github.com/benohara Can either of you link to a use of this in
practical code? The example code does not make sense, as ensure should be
a quoted word where it's being used as a hash key.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#410 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AJQNzMJOyEVLg2u8fnywd8qDPr4iWVG9ks5qPLDhgaJpZM4D1NZ3
.

[rnelson0]

@jamesooden I wasn't seeing the context properly, but I see it now. Working on a PR.

[rnelson0]

Fixed in #490. Thanks!

[Fabian1976]

Is this allready in a release? Because with the most recent version of lint (2.3.6), I still get this error:

manifests/profile/citrix/vda.pp - WARNING: ensure found on line but it's not the first attribute on line 47

This is the piece of code:

  dsc { 'xWindowsFeature_RDS-RD-Server':
    notify                  => Reboot['After_Features'],
    dsc_resource_name       => 'xWindowsFeature',
    dsc_resource_module     => 'xPSDesiredStateConfiguration',
    dsc_resource_properties => {
      ensure               => 'present',
      name                 => 'RDS-RD-Server',
      psdscrunascredential => {
        dsc_type       => 'MSFT_Credential',
        dsc_properties => $admin,
      },
    },
  }

[rodjek]

Confirmed that this seems to have regressed.