Ignore cron commands over 80 characters long

[kormoc]

Spacing, Indentation & Whitespace

Should not exceed an 80 character line width
An exception has been made for source => 'puppet://...' lines as splitting these over multiple lines decreases the readability of the manifests.

I would argue that command => '' should also be excluded, as paths can be really long and can't be shortened without breaking the string abnormally

[vStone]

You can easily put long commands in a template. That also resolves the quote-madness that sometimes arises.

[kormoc]

command => template("my_module/command.erb") ?

That seems overly complex for a single line that may just be 90 characters, but fair 'nuff

[ghoneycutt]

80 char limit sadly snuck into the style guide, which is why there is a check in puppet-lint. It only triggers a WARNING and is easily disabled. Highly recommend just disabling that check on your systems, though I do not believe that lint should have exceptions as it is just responding to the style guide.

[dbeckham]

I generally do disable the 80 char limit for automated testing, but it is a good lint check for cases when you might have accidentally created a really long require => [File[foo], Package[bar], ...]. Quite a few exec related resource attributes just can't be broken up and templates for one liners that happen to be over 80 chars is just another work around. I have no idea how easy it would be, or if it would just create config complexity, but being able to specify resource attributes to ignore would mean you could tailor it to your environment.

[rodjek]

As pointed out earlier in this issue, the recommended work around is to put it into a template or disable the check. I don't want to start making exceptions for every long line as it starts a horrible trend of people asking for exceptions for things like the authorized_key type so they can embed a 4096 character key in their manifests and so on.