Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet-lint should warn on files that do not end with a trailing newline #188

Closed
wfarr opened this issue Feb 26, 2013 · 7 comments
Closed

Comments

@wfarr
Copy link
Contributor

wfarr commented Feb 26, 2013

this is 2013

👑💩

@rodjek
Copy link
Owner

rodjek commented Feb 26, 2013

Yeah, well, that's just, like, your opinion, man

@pickgr
Copy link

pickgr commented Apr 30, 2014

I'd be interested in this feature as well.

@Aethylred
Copy link

trailing newlines are not in the style guide...

@ghoneycutt
Copy link
Contributor

+1 to @Aethylred

@wfarr great suggestion for puppet parser validation. I've been bit on line endings before (thank you perforce for that feature of changing them for me) and this functionality would have saved me a ton.

@Aethylred
Copy link

Slightly off topic, similarly Windows line endings (CRLF) should be picked up by the parser and not puppet-lint doing style checks. (usually more of an issue for Ruby than Puppet...)

@rodjek
Copy link
Owner

rodjek commented Aug 19, 2014

This check has been implemented as an external plugin https://github.com/rodjek/puppet-lint-trailing_newline-check

@rodjek rodjek closed this as completed Aug 19, 2014
@markchalloner
Copy link

May be worth re-opening this and integrating the plugin as a first-class feature the docs now specifically mention ending the last line with a new line.

bastelfreak pushed a commit to bastelfreak/puppet-lint that referenced this issue Mar 22, 2024
…d_on_prs

pdksync - (CAT-770) - Update mend to run on pull_request_target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants