Python 3.10 fix co_lines parsing of co_linetable #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jdw170000 <[email protected]>
|
I'll take your word for it, but I don't see how this code necessarily follows https://github.com/python/cpython/blob/3.10/Objects/codeobject.c#L1030 . It looks like we want to follow PyLineTable_NextAddressRange and from that advance(). Also, it would be nice to have a test that shows the difference. This can come as a future PR though. |
|
Yes ok makes sense, will do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of
co_linetablein 3.10 was still slightly broken, caught the issues with the new cross version tests. @jdw170000 found that the first linetable entry will have a line delta of 0, and was being skipped in some cases. This new algorithm follows the C code in 3.10 cpython instead of the example python snippet given.