add minetest server

[mikey0000]

To ease and accelerate the PR submission, please use the template below to provide all requested information.
You can find guidelines on which docker image to use in the Rockstor's documentation,
as well as examples of proper formatting in other rock-ons (here
and here)

Fixes # .

General information on project

This pull request proposes to add a new rock-on for the following project:

• name: Minetest
• website: minetest.net
• description: Rockon for minetest server

Information on docker image

• docker image: r/linuxserver/minetest
• is an official docker image available for this project?:
  using the linuxserver.io image

Checklist

• Passes JSONlint validation
• Entry added to root.json in alphabetical order (for new rock-on only)
• "description" object lists and links to the docker image used
• "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
• "website" object links to project's main website

[mikey0000]

Hi guys, please feel free to make suggestions on a better description, I might try for a better one tomorrow.

[mikey0000]

Is there a way to set args as an optional instead of required?

[phillxnet]

@mikey0000 Hello again, and thanks for another Rock-on submission.

Can't look too closely at this pr right now but they appear to have an ssl cert issue with their site:
https://minetest.net/
We should probably reach out to them on that front.

Is there a way to set args as an optional instead of required?

Don't think so, at least yet, but @FroggyFlox should be able to confirm or deny that one as they have been working with that part of the code more recently. We do have an optional "devices" section now however so there is precedent.

[mikey0000]

@mikey0000 Hello again, and thanks for another Rock-on submission.

Can't look too closely at this pr right now but they appear to have an ssl cert issue with their site:
https://minetest.net/
We should probably reach out to them on that front.

Is there a way to set args as an optional instead of required?

Don't think so, at least yet, but @FroggyFlox should be able to confirm or deny that one as they have been working with that part of the code more recently. We do have an optional "devices" section now however so there is precedent.

Cool, yeah looks like they actually don't have https on the main website, did https by default as their wiki supports it.

[FroggyFlox]

Hi @mikey0000 ,

Sorry for not getting back with you earlier than that.

Is there a way to set args as an optional instead of required?

Don't think so, at least yet, but @FroggyFlox should be able to confirm or deny that one as they have been working with that part of the code more recently. We do have an optional "devices" section now however so there is precedent.

We indeed cannot do that at the moment, but we do have it planned in the not-so-distant future. We do have a corresponding issue to track it:
rockstor/rockstor-core#2094 (comment)

For the time being, I'm tempted to recommend removing the CLI_ARGS env because of it, and we can always put it back once optional environment variables are possible. I couldn't test whether or not the minetest instance was indeed reachable, but from the logs, it seems to start without error. This is, of course, without the CLI_ARGS defined.

What do you think about removing it? Does it actually remove important features? As they are defined as optional on the docker hub documentation, I tend to believe we can do without them at the moment but I'm not a Minetest user so I can't know for sure. Is there any setting that can only be defined through the CLI_ARGS environment variable and not through the conf files, for instance?

[mikey0000]

Yeah it can be set in the conf so can remove it. 14/06/2020 12:58:28 am FroggyFlox <[email protected]>:

…

Hi @mikey0000[https://github.com/mikey0000] , Sorry for not getting back with you earlier than that. >> Is there a way to set args as an optional instead of required? > Don't think so, at least yet, but @FroggyFlox[https://github.com/FroggyFlox] should be able to confirm or deny that one as they have been working with that part of the code more recently. We do have an optional "devices" section now however so there is precedent. > We indeed cannot do that at the moment, but we do have it planned in the not-so-distant future. We do have a corresponding issue to track it: rockstor/rockstor-core#2094 (comment)[rockstor/rockstor-core#2094 (comment)] For the time being, I'm tempted to recommend removing the CLI_ARGS env because of it, and we can always put it back once optional environment variables are possible. I couldn't test whether or not the minetest instance was indeed reachable, but from the logs, it seems to start without error. This is, of course, without the CLI_ARGS defined. What do you think about removing it? Does it actually remove important features? As they are defined as optional on the docker hub documentation, I tend to believe we can do without them at the moment but I'm not a Minetest user so I can't know for sure. Is there any setting that can only be defined through the CLI_ARGS environment variable and not through the conf files, for instance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[#225 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AALDOPMR3STLESA7I3OBFQLRWNZVXANCNFSM4MRYTDIA]. [https://github.com/notifications/beacon/AALDOPJPMIL6DJSNCCKTBX3RWNZVXA5CNFSM4MRYTDIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEZON3LQ.gif]

[mikey0000]

@FroggyFlox I finally removed the cli args 😺

[FroggyFlox]

My previous review still stands as it seems to be working for me with the caveat that I'm unable to test a successful connection to the server, but all logs seem OK.

[FroggyFlox]

Hi @mikey0000 ,

First of all, sorry again for such a delay in getting to your submission...
I've now re-tested and it still works as intended, thanks a lot for your original submission and your continued time and effort in making the revisions!

As you can see in the review, I only noticed a minor improvement that we can make in the description of the TZ environment variable. I believe we can merge your PR once that minor edit is included.

Sorry again for such a delay in getting to this.

[mikey0000]

Ah sorry must have missed that one, will address it. No worries we all have lives outside github 😁 26/08/2020 1:14:50 am FroggyFlox <[email protected]>:

…

Hi @mikey0000[https://github.com/mikey0000] , First of all, sorry again for such a delay in getting to your submission... I've now re-tested and it still works as intended, thanks a lot for your original submission and your continued time and effort in making the revisions! As you can see in the review, I only noticed a minor improvement that we can make in the description of the TZ environment variable. I believe we can merge your PR once that minor edit is included. Sorry again for such a delay in getting to this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[#225 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AALDOPN2JAZKGPHQNXXSFB3SCO2K3ANCNFSM4MRYTDIA]. [https://github.com/notifications/beacon/AALDOPL4WY2G5QPEE3D6JUDSCO2K3A5CNFSM4MRYTDIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFCED2PQ.gif]

[mikey0000]

Hey guys life happens and I completely forgot about finishing this. Will address right now.

[FroggyFlox]

Hi @mikey0000 ,

Thanks a lot for following-up and making the changes! With all the time it took me to review it, I unfortunately have another small suggestion that I would like to see included. As you can see, it only relates to an harmonization of the "description" field with other rock-ons that we now try to follow.

Everything else still works as intended so I'll merge your PR once we have that little addition to the "description" field in.

Thanks again!

[mikey0000]

@FroggyFlox I think I addressed the description?

[phillxnet]

@mikey0000 What do you know, we finally got this one sorted.

Adding as initially reviewed by @FroggyFlox with a light install test by myself:

[03/Feb/2023 15:28:41] DEBUG [system.osi:208] Running command: /usr/bin/docker pull linuxserver/minetest:latest
[03/Feb/2023 15:28:49] DEBUG [system.osi:208] Running command: /usr/bin/docker run -d --restart=unless-stopped --name minetest -v /mnt2/minetest-config:/config/.minetest -v /etc/localtime:/etc/localtime:ro -p 30000:30000/udp -e PUID=1010 -e TZ=Europe/Lisbon -e PGID=100 linuxserver/minetest:latest
[03/Feb/2023 15:28:50] DEBUG [storageadmin.views.rockon_helpers:210] Set rock-on 91 state to installed
[03/Feb/2023 15:28:50] INFO [storageadmin.tasks:64] Task [install], id: 22fcc389-179d-4d97-a182-efe31c6cc122 completed OK

Thanks all around for the super long persistent tail on this one. Lets just get it in, and out, to get some field testing on it.

[phillxnet]

As per comments, this super long tail has likely come to an end.
I'll pop in as it looks like all requested changes have been applied.

[phillxnet]

[phillxnet]

Merging as I believe @FroggyFlox's requests are also now merged via git.

[mikey0000]

🎉 thanks @phillxnet, nice to see it finally make it.

[phillxnet]

@mikey0000 Yes, it's great to get Rock-ons finally through review. Always tweaks that can be made however so bit of a balancing act.

I've just now published the recent changes in this repository to production so this and a number of other Rock-ons should now show up after an "Update" button push in the Rock-ons page (All tab).

Thanks again for hanging in there.