Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward Tree v10: Errata and Clarifications #311

Merged
merged 7 commits into from
Dec 15, 2024

Conversation

haloooloolo
Copy link
Contributor

@haloooloolo haloooloolo commented Nov 11, 2024

  • changes interval variable name to currentIndex to match previous reference to the reward interval
  • specifically states that bonus commission eligibility is also subject to standard smoothing pool eligibility criteria
  • specifically states that no bonus should be awarded if eligibleStartTimeeligibleEndTime
  • removes getMinipoolBonus function to simplify the spec as it was only called once
  • changes getTotalNodeFee arguments from baseFee, percentOfBorrowedETH to minipoolFee, minipoolBond
  • fixes typo: totalEthForMinipool -> totalEthForMinipools
  • removes beacon balance queries from consensus income calculation due to performance issues

Co-authored-by: Jacob Shufro <[email protected]>
@haloooloolo haloooloolo marked this pull request as ready for review December 7, 2024 00:27
Copy link
Collaborator

@Valdorff Valdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I'm not an expert here.

Written by @haloooloolo. @jshufro agreed it was ready to be merged. I did not see an explicit go-ahead from @xrchz (the other person active on reward tree work), but I have seen work on their end with this spec and no complaints.

@Valdorff Valdorff merged commit 906b1ca into rocket-pool:main Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants