Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsb-release for shiny-server #575

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Dec 9, 2022

As a result of lsb-release being removed from rocker/r-ver in #511, it appears that install_shiny_server.sh is no longer functional.
We need to install lsb-release for shiny-server.

@eitsupi eitsupi added the bug Something isn't working label Dec 9, 2022
@cboettig
Copy link
Member

ha, good catch. LGTM, merge when ready

@eitsupi
Copy link
Member Author

eitsupi commented Dec 10, 2022

I missed this in #511 because a test case was missing, so I added a test case in c2379fe.

@eitsupi eitsupi merged commit f2063d7 into rocker-org:master Dec 10, 2022
@eitsupi eitsupi deleted the add-shiny-lsb-release branch December 10, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants