Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Push images to GitHub Container registry too #456

Merged
merged 10 commits into from
May 25, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented May 20, 2022

Close #371

Add tags like ghcr.io/rocker-org/r-ver:latest to push the same images to GitHub Container registry as to DockerHub.
Of course, the GitHub Actions workflow files also need a little updating to push images to ghcr.

@eitsupi eitsupi changed the title WIP: Push images to GitHub Container registry too WIP: [CI] Push images to GitHub Container registry too May 20, 2022
@eitsupi eitsupi marked this pull request as ready for review May 24, 2022 13:41
@eitsupi eitsupi changed the title WIP: [CI] Push images to GitHub Container registry too [CI] Push images to GitHub Container registry too May 24, 2022
@eitsupi eitsupi requested a review from cboettig May 24, 2022 13:42
@eitsupi
Copy link
Member Author

eitsupi commented May 25, 2022

@cboettig For now, no new tags have been added to images prior to R 4.1.3. How do you think it?

@cboettig
Copy link
Member

Looks reasonable to me. We might want to push the older tags as well for completeness but probably not a priority. Does this need any further config on my end for the GH registry?

@eitsupi
Copy link
Member Author

eitsupi commented May 25, 2022

No secret or other settings are required, but additional steps would have been needed to make the images registered in the registry public (should be after the package is first registered...).
At any rate, we should see it after the next build is done.

@eitsupi eitsupi merged commit 85ef060 into rocker-org:master May 25, 2022
@eitsupi eitsupi deleted the push-to-ghcr branch May 25, 2022 16:21
@eitsupi
Copy link
Member Author

eitsupi commented May 25, 2022

I triggered the extra build workflow by hand (to build dev-osgeo) and it works!
https://github.com/rocker-org/rocker-versioned2/pkgs/container/geospatial

image

@eitsupi
Copy link
Member Author

eitsupi commented May 25, 2022

In the end, no additional steps were needed.
I simply added a step to log into GHCR on the workflow and added the tags and it worked.
(I did change the settings to make images registered in this repository invisible a long time ago because it was confusing, but that has nothing to do with the tags that now pushes).

@eitsupi
Copy link
Member Author

eitsupi commented May 25, 2022

We can verify that images with the exact same digest are available on DockerHub and GitHub.

image
image

@cboettig
Copy link
Member

this is fantastic. Excellent work, thanks @eitsupi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dockerhub rate limiting
2 participants