Improve testing and refactoring of rocker scripts #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(NB_USER) if it does not exist
- Python is now installed by `install_binder.sh` - rewrite `CMD` to exec form
version specification is deleted because the installation log is not output when >=2.0 is written
and add installation of lsb-release (this is basically included in the base image)
and remove git from `install_binder.sh` dependencies
eitsupi
force-pushed
the
eitsupi/refactoring-scripts-and-minor-improvement
branch
2 times, most recently
from
876034c to
3a72dfa
Compare
eitsupi
force-pushed
the
eitsupi/refactoring-scripts-and-minor-improvement
branch
from
3a72dfa to
4b0dead
Compare
eitsupi
force-pushed
the
eitsupi/refactoring-scripts-and-minor-improvement
branch
from
4b0dead to
e6cd271
Compare
and minor improvements (reordering of some lines and remove unnecessary lines)
eitsupi
force-pushed
the
eitsupi/refactoring-scripts-and-minor-improvement
branch
from
e59642e to
4dd87e1
Compare
|
It passed the tests and should work fine, so I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases and refactor each script.
With this change, all scripts used in pre-built images (except extra images) will be tested.
install_cuda-10.1.shinstall_cuda-11.1.shconfig_R_cuda.sh(mainly removing unnecessary
apt update, which can affect run time, especially in places far from the United States)This PR includes the following PR tasks
(Originally, I think it is better to separate Pull Requests for each modification, but to avoid conflicts in the test definition file, I have put them together in one PR.)
install_rstudio.shfor suportingubuntu:jammy(Support installing RStudio Server for Ubuntu 22.04 #435)install_binder.shto be able to run alone (Allowsinstall_binder.shto be independently executable #438)And some other fixes.
install_cuda-10.1.sh#442)