Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Versions.md to the wiki #334

Merged
merged 10 commits into from
Mar 10, 2022
Merged

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Jan 14, 2022

Related to #201

Now that #328 has been merged, we can generate a table to see the list of configuration values for each version, like https://github.com/rocker-org/rocker-versioned/blob/master/VERSIONS.md
I think it would be useful if this could be registered in the wiki and automatically updated.

Screen shot

Versions.md

image

sidebar

image

ToDo

  • Add sidebar of the wiki
  • Update the job to update wiki
  • Update build/README.md (About the disappearance of the corresponding version from Versions.md when the stackfile is deleted)

@eitsupi eitsupi changed the title Add versions.md to the wiki Add Versions.md to the wiki Jan 15, 2022
@eitsupi eitsupi mentioned this pull request Jan 15, 2022
8 tasks
@behrica
Copy link

behrica commented Jan 25, 2022

I am just trying a Dockerfile with simply having:

FROM rocker/rstudio:4.0.3
RUN Rscript -e 'install.packages(c("httr","rlist","dplyr","purrr","stringr","AzureTableStor","lubridate","uuid"))'
RUN Rscript -e 'install.packages(c("rjson","tidyr"))'

and I get some unexpected warnings: that packages were compiled with R 4.0.5 (while the image tag I use is 4.0.3).
This seems strange to me.

Additionally the date in the repository is "not matching" your table above:

getOption("repos")
                                                                CRAN 
"https://packagemanager.rstudio.com/cran/__linux__/focal/2021-02-17" 

Is this expected ?

@eitsupi
Copy link
Member Author

eitsupi commented Jan 25, 2022

Yes, that's one of the reasons I'm keeping this PR in draft.

As you found, the CRAN mirror for that container images are dated differently than the original rule, the Dockerfile fix was implemented half a month ago (#328) and no container image built with the modified Dockerfile has been pushed yet.
Therefore, the containers currently used by the users do not match this document.

The current build system is such that Docker images containing older R versions will be built at the time of the new R release, so the documentation will match the actual state in a few months when R4.1.3? is released.

@eitsupi
Copy link
Member Author

eitsupi commented Jan 25, 2022

https://www.rocker-project.org/use/extending/

You may find this page helpful. For example, if you build an image from the following Dockerfile, you can modify CRAN and install the package.

FROM rocker/rstudio:4.0.3

RUN echo 'options(repos = c(CRAN = "https://packagemanager.rstudio.com/cran/__linux__/focal/2021-02-11"))' >> ${R_HOME}/etc/Rprofile.site

RUN install2.r --error --skipinstalled --ncpus -1 httr rlist dplyr purrr stringr AzureTableStor lubridate uuid rjson tidyr

@eitsupi eitsupi marked this pull request as ready for review February 10, 2022 15:57
@eitsupi
Copy link
Member Author

eitsupi commented Feb 10, 2022

I'm done editing, but for the next few months (until the release of R4.1.3) the CRAN dates will continue to be inconsistent between this document and the container images we can pull from DockerHub, so do you think it might be better not to merge until the release of R4.1.3?

@eitsupi eitsupi marked this pull request as draft February 21, 2022 10:29
@eitsupi eitsupi added this to the R 4.1.3 milestone Feb 21, 2022
@eitsupi
Copy link
Member Author

eitsupi commented Feb 21, 2022

I will merge this when R 4.1.3 is released.

@eitsupi eitsupi marked this pull request as ready for review March 9, 2022 10:54
@eitsupi eitsupi merged commit 0d0d556 into rocker-org:master Mar 10, 2022
@eitsupi eitsupi deleted the add-versions-doc branch March 10, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants