Approvers now get Write permission (open-telemetry#88)

* Approvers now get Write permission In order to support CODEOWNERS for approvers (no GH action), grant approvers Write access. This follows the OTel model. Addresses open-telemetry#87 * Remove action * Re-add CODEOWNERS template * Fix files * Update specification/templates/.github/CODEOWNERS Co-authored-by: Tyler Yahn <[email protected]> * Update specification/templates/.github/CODEOWNERS Co-authored-by: Mateusz Rzeszutek <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Mateusz Rzeszutek <[email protected]>
rockb1017 · May 13, 2021 · de2476d · de2476d
1 parent dd1a59c
commit de2476d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 25 deletions.
diff --git a/specification/repository.md b/specification/repository.md
@@ -24,7 +24,7 @@ approval is granted, GDI projects MUST NOT cut a GA release.
 - MUST grant `Maintain` [permission
   level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
   to maintainers team
-- MUST grant `Triage` [permission
+- MUST grant `Write` [permission
   level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
   to approvers team
 - MUST NOT grant `Write`, `Maintain`, `Admin` [permission
@@ -91,9 +91,7 @@ approval is granted, GDI projects MUST NOT cut a GA release.
 - MUST add [CODE_OF_CONDUCT.md](templates/CODE_OF_CONDUCT.md)
 - MUST add [CONTRIBUTING.md](templates/CONTRIBUTING.md)
 - MUST have a [.github/CODEOWNERS](templates/.github/CODEOWNERS) file with a maintainers team
-- SHOULD have a
-  [.github/workflows/request-reviews.yml](templates/.github/workflows/request-reviews.yml)
-  to automate requesting reviews from approvers
+- SHOULD have an approvers team in CODEOWNERS
 - MUST have an Apache 2.0 `LICENSE` file
 - SHOULD have a `MIGRATING.md` if applicable
 - MUST have a `README.md`

diff --git a/specification/templates/.github/CODEOWNERS b/specification/templates/.github/CODEOWNERS
@@ -1,5 +1,6 @@
-# Learn about CODEOWNERS file format:
 #  https://help.github.com/en/articles/about-code-owners
 #
 # Global Owners
-* @signalfx/TEAM-maintainers
+* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers
+
+.github/CODEOWNERS @signalfx/gdi-TEAM-maintainers
diff --git a/specification/templates/.github/workflows/request-reviews.yml b/specification/templates/.github/workflows/request-reviews.yml